Skip to content

Commit

Permalink
Skip array type tests due to occsional segfaults (#1187)
Browse files Browse the repository at this point in the history
#### Reference Issues/PRs
There are problems with numpy arrays leading to non-deterministic
segfaults. See #1186

#### What does this implement or fix?
For now skip the tests so that they don't mess the CI
#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->

Co-authored-by: Vasil Pashov <vasil.pashov@man.com>
  • Loading branch information
vasil-pashov and Vasil Pashov authored Jan 2, 2024
1 parent da5f02b commit d89a6ef
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def assert_db_in_out_match(version_store, df_in, symbol):
assert_frame_equal(df_in, df_out.data)


@pytest.mark.skip(reason="Arrays occasionally raise segfault")
class TestEmptyArrays:
def test_single_empty_array(self, lmdb_version_store):
df_in = pd.DataFrame({"col1": [np.array([])]})
Expand Down Expand Up @@ -85,6 +86,7 @@ def test_can_append_empty_array_to_emptyval(self, lmdb_version_store):
assert_frame_equal(df_target, df_out.data)


@pytest.mark.skip(reason="Arrays occasionally raise segfault")
class TestNonEmptyArrays:
def test_single_array(self, lmdb_version_store, array_type):
df_in = pd.DataFrame({"col1": [np.array([1, 2, 3]).astype(array_type)]})
Expand Down Expand Up @@ -124,6 +126,7 @@ def test_can_append(self, lmdb_version_store, array_type):
assert_frame_equal(df_target, df_out.data)


@pytest.mark.skip(reason="Arrays occasionally raise segfault")
class TestFailure:
def test_cannot_mix_scalars_and_arrays(self, lmdb_version_store):
with pytest.raises(Exception):
Expand Down

0 comments on commit d89a6ef

Please sign in to comment.