build: Remove old Cython configuration and adaptation #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unneeded pieces of legacy configuration. Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Qi Chen <Qi.Chen@man.com>
jjerphan
force-pushed
the
build/remove-BUILD_CYTHON
branch
from
48d460f
to
a1fd592
Compare
JohanMabille
approved these changes
Nov 2, 2023
jjerphan
changed the title
BUILD_CYTHON_*
alexowens90
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None.
What does this implement or fix?
The project used to use Cython to compile native extension.
This is not the case anymore, but a few elements remains.
This PR remove them.
Any other comments?
Are there any other pieces which we can remove?
Checklist
Checklist for code changes...