Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin all our Github actions deps #1090

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Pin all our Github actions deps #1090

merged 1 commit into from
Nov 21, 2023

Conversation

poodlewars
Copy link
Collaborator

This is because floating deps can break our build without code changes in ArcticDB.

None left after this except softprops/, which only has a v1 tag.

➜  .github git:(pin-actions) ✗ rg -i "uses: " . | grep "@" | grep -v "@v[0-9\.]{3}"
./workflows/publish.yml:        uses: softprops/action-gh-release@v1
➜  .github git:(pin-actions) ✗ pwd
/home/alex/source/ArcticDB/.github

This is because floating deps can break our build without code changes
in ArcticDB.

None left after this except softprops/, which only has a v1 tag.

```
➜  .github git:(pin-actions) ✗ rg -i "uses: " . | grep "@" | grep -v "@v[0-9\.]{3}"
./workflows/publish.yml:        uses: softprops/action-gh-release@v1
➜  .github git:(pin-actions) ✗ pwd
/home/alex/source/ArcticDB/.github
```
@poodlewars poodlewars added the bug Something isn't working label Nov 20, 2023
@jamesmunro jamesmunro self-requested a review November 21, 2023 16:07
@poodlewars poodlewars merged commit 5aab6b5 into master Nov 21, 2023
131 checks passed
@poodlewars poodlewars deleted the pin-actions branch November 21, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants