Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1173: Correctly apply sortedness checks when calling update with date_range argument #1238

Conversation

alexowens90
Copy link
Collaborator

Closes #1173

Also:

  • Set the sortedness field to UNKNOWN for all non-timestamp indexed dataframes. Previously, this would be set to ASCENDING/DESCENDING for int/range indexes based on the DataFrame.is_monotonic_<in|de>creasing of the input df, but this information was not used for anything
  • Fixes the docstring of the returned dict from NativeVersionStore.get_info to include the sorted key
  • Add the sorted field to the SymbolDescription class returned from Library.get_info
  • Simplifies and extends the tests for sortedness checks with update

@alexowens90 alexowens90 force-pushed the bugfix/1173/update-can-bypass-index-sortedness-checks-if-date-range-arg-provided branch from 1a31bf2 to 22498dd Compare January 16, 2024 15:13
@alexowens90 alexowens90 merged commit 19ef591 into master Jan 16, 2024
130 checks passed
@alexowens90 alexowens90 deleted the bugfix/1173/update-can-bypass-index-sortedness-checks-if-date-range-arg-provided branch January 16, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update can succeed on unsorted data when the date_range argument is used
2 participants