#406 and #1245 support sortedness checks and maintenance with parallel writes and appends #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poodlewars
reviewed
Jan 18, 2024
| @@ -2433,7 +2433,10 @@ def is_symbol_pickled(self, symbol: str, as_of: Optional[VersionQueryInput] = No | |||
| return self.is_pickled_descriptor(dit.timeseries_descriptor) | |||
|
|
|||
| def _get_time_range_from_ts(self, desc, min_ts, max_ts): | |||
| if min_ts == None or max_ts == None: | |||
| if desc.stream_descriptor.index.kind != IndexDescriptor.Type.TIMESTAMP or \ | |||
There was a problem hiding this comment.
Wasn't this in the other PR? Does this one need a rebase?
There was a problem hiding this comment.
Yep, rebased now
poodlewars
reviewed
Jan 18, 2024
| def test_parallel_sortedness_checks(lmdb_version_store, append): | ||
| lib = lmdb_version_store | ||
| sym = "test_parallel_sortedness_checks" | ||
| if append: |
There was a problem hiding this comment.
Lots of the tests from here down are substantially different depending on append. I think it would be clearer to explode out to separate tests rather than parameterizing.
There was a problem hiding this comment.
I disagree on this. The core features under test are identical for write and append. Having them parametrized makes it clear that they should behave the same way.
poodlewars
approved these changes
Jan 18, 2024
alexowens90
force-pushed
the
bugfix/406/support-sortedness-checks-with-parallel-writes-and-appends
branch
2 times, most recently
from
149a613
to
e9d868b
Compare
…nds, and maintain sortedness information in compact_incomplete
alexowens90
force-pushed
the
bugfix/406/support-sortedness-checks-with-parallel-writes-and-appends
branch
from
e9d868b
to
6ec7ae7
Compare
alexowens90
deleted the
bugfix/406/support-sortedness-checks-with-parallel-writes-and-appends
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #406
Closes #1245