S3 local delete failure raising meaningful error #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously on a local delete failure we would have raised a KeyNotFoundException which is quite misleading - Now we raise a E_UNEXCPETED_S3_ERROR with additional error messages
IvoDD
force-pushed
the
meaningful-s3-local-delete-error
branch
2 times, most recently
from
eb0ad90
to
65b2305
Compare
poodlewars
reviewed
Feb 15, 2024
| @@ -202,7 +202,7 @@ namespace s3 { | |||
| ARCTICDB_SUBSAMPLE(S3StorageDeleteBatch, 0) | |||
| auto fmt_db = [](auto &&k) { return variant_key_type(k); }; | |||
| std::vector<std::string> to_delete; | |||
| std::vector<VariantKey> failed_deletes; | |||
| std::vector<std::pair<VariantKey, std::string>> failed_deletes; | |||
There was a problem hiding this comment.
Minor but a struct rather than the pair might be more readable?
| if (!failed_deletes.empty()){ | ||
| auto failed_deletes_message = std::ostringstream(); | ||
| for (auto i=0u; i<failed_deletes.size(); ++i){ | ||
| auto& failed = failed_deletes[i]; |
There was a problem hiding this comment.
If we keep the pair then consider expanding it with a structured binding here rather than .first and .second
| @@ -240,8 +241,19 @@ namespace s3 { | |||
|
|
|||
| util::check(to_delete.empty(), "Have {} segment that have not been removed", | |||
| to_delete.size()); | |||
| if (!failed_deletes.empty()) | |||
| throw KeyNotFoundException(Composite<VariantKey>(std::move(failed_deletes))); | |||
| if (!failed_deletes.empty()){ | |||
There was a problem hiding this comment.
Space before { please 🙏
poodlewars
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...