#447 Exception normalization for RocksDB #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammadhamzasajjad
force-pushed
the
rocksdb_storage_exceptions
branch
2 times, most recently
from
eff3300
to
c364fe8
Compare
muhammadhamzasajjad
requested review from
poodlewars and
joe-iddon
and removed request for
poodlewars
joe-iddon
requested changes
Feb 27, 2024
poodlewars
reviewed
Feb 27, 2024
| log::storage().debug("Failed to read segment for key {}", variant_key_view(k)); | ||
| failed_reads.push_back(k); | ||
| } | ||
| else { |
There was a problem hiding this comment.
(nit) we usually have the else on the line above
There was a problem hiding this comment.
Fixed in 9fed291.
| @@ -125,10 +126,18 @@ void RocksDBStorage::do_read(Composite<VariantKey>&& ks, const ReadVisitor& visi | |||
| std::string k_str = to_serialized_key(k); | |||
| std::string value; | |||
| auto s = db_->Get(::rocksdb::ReadOptions(), handle, ::rocksdb::Slice(k_str), &value); | |||
| util::check(s.ok(), DEFAULT_ROCKSDB_NOT_OK_ERROR + s.ToString()); | |||
| visitor(k, Segment::from_bytes(reinterpret_cast<uint8_t*>(value.data()), value.size())); | |||
| storage::check<ErrorCode::E_UNEXPECTED_ROCKSDB_ERROR>(s.IsNotFound() || s.ok(), DEFAULT_ROCKSDB_NOT_OK_ERROR + s.ToString()); | |||
There was a problem hiding this comment.
Ah I see OK, so this is where we could extend the error handling later to handle additional statuses from https://github.com/facebook/rocksdb/blob/main/include/rocksdb/status.h
muhammadhamzasajjad
force-pushed
the
rocksdb_storage_exceptions
branch
from
ffb43cd
to
9fed291
Compare
joe-iddon
approved these changes
Feb 27, 2024
poodlewars
approved these changes
Feb 28, 2024
5 tasks
muhammadhamzasajjad
added a commit
that referenced
this pull request
Mar 14, 2024
This is the final PR for exception normalization. Previous PRs are #1411, #1360, #1344, #1304, #1297 and #1285 #### Reference Issues/PRs Previously #1285 only normalized `KeyNotFoundException` and `DuplicateKeyException` correctly. As mentioned in [this comment](#1285 (comment)), we need to normalize other lmdb specific errors too. This PR does that. A mock client is also created to simulate the lmdb errors which aren't easily produce-able with real lmdb but can occur. The ErrorCode list has been updated in `error_code.hpp`. Previously, all the storage error codes were just sequential. This required that each time a new error was added for a specific storage, all the other error codes needed to be changed as we want to assign sequential error codes to the same storage. We now leave 10 error codes for each storage which allows us to easily add new error codes for a storage without having to change all the others. `::lmdb::map_full_error` is now normalized. When this error occurs, lmdb throws `LMDBMapFullException` which is child of `StorageException` #### What does this implement or fix? #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs normalization of RocksDB storage exceptions as per #584.
Checklist
Checklist for code changes...