Support generators for metadata vectors again #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poodlewars
reviewed
Mar 22, 2024
| else: | ||
| metadata_itr = iter(metadata_vector) | ||
| metadata_vector = list(iter(metadata_vector)) |
poodlewars
reviewed
Mar 22, 2024
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| As of the Change Date specified in that file, in accordance with the Business Source License, use of this software will be governed by the Apache License, version 2.0. | |||
| """ | |||
| import copy | |||
poodlewars
approved these changes
Mar 22, 2024
alexowens90
deleted the
bugfix/restore-support-for-metadata-vector-generators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in #1444 but users of the V1 API may be relying on this behaviour