Align azure timeout with s3 #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poodlewars
requested changes
Apr 10, 2024
| @@ -362,7 +362,7 @@ AzureStorage::AzureStorage(const LibraryPath &library_path, OpenMode mode, const | |||
| } else | |||
| ARCTICDB_RUNTIME_DEBUG(log::storage(), "Azure prefix not found, will use {}", root_folder_); | |||
| unsigned int max_connections = conf.max_connections() == 0 ? ConfigsMap::instance()->get_int("VersionStore.NumIOThreads", 16) : conf.max_connections(); | |||
| upload_option_.TransferOptions.Concurrency = max_connections; | |||
| upload_option_.TransferOptions.Concurrency = max_connections; | |||
There was a problem hiding this comment.
Sorry it doesn't show up in my diff. 😢
phoebusm
force-pushed
the
fix/increase_azure_timeout
branch
from
3a08edb
to
55ba79e
Compare
poodlewars
approved these changes
Apr 11, 2024
phoebusm
force-pushed
the
fix/increase_azure_timeout
branch
from
55ba79e
to
15857f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fix #1026
What does this implement or fix?
Azure timeout has been incorrectly set to 60000ms. It needs to be addressed
Any other comments?
Checklist
Checklist for code changes...