-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/1507/disallow appending row range to datetime index with dynamic schema #1517
Closed
alexowens90
wants to merge
10
commits into
master
from
bugfix/1507/disallow-appending-row-range-to-datetime-index-with-dynamic-schema
Closed
Bugfix/1507/disallow appending row range to datetime index with dynamic schema #1517
alexowens90
wants to merge
10
commits into
master
from
bugfix/1507/disallow-appending-row-range-to-datetime-index-with-dynamic-schema
Commits on Apr 2, 2024
-
Implement empty index for 0-rowed columns (#1429)
#### Reference Issues/PRs Closes: #1428 #### What does this implement or fix? Create an empty-index type. This required change in the Python and in the C++ layer. * In the C++ layer an new index type was added. (IndexDescriptor::EMPTY). It does not allocate a filed in the storage (similar to how row range index does not allocate a field). The checks for index compatibility are relaxed, the empty index is compatible with all other index types and it gets overridden the first time a non-empty index is written (either through update or append). On write we check if the dataframe contains 0 rows and if so it gets assigned an empty index. * The logic in the python layer is dodgy and needs discussion. In the current state the normalization metadata and the index descriptor are stored separately. There is one proto message describing both DateTime index and Ranged Index. The current change made it so that in case of 0 rows the python layer passes RowRange index to the C++ layer which checks if there are any rows in the DF. If there are rows Row range index is used, otherwise empty index is used. Note the `is_not_range_index` proto field. IMO it needs some refactoring in further PRs. It's used in the python layer to check if the first column is index or not. #### Any other comments? Merge this after: #1436 #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing --> --------- Co-authored-by: Vasil Pashov <vasil.pashov@man.com>
Configuration menu - View commit details
-
Copy full SHA for a14eb48 - Browse repository at this point
Copy the full SHA a14eb48View commit details -
Dev/vasil.pashov/index file refactor (#1472)
Refactor index.hpp Move the functions in a .cpp file. Add explicit template instantiations for the CRTP base class in the cpp file. #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing --> --------- Co-authored-by: Vasil Pashov <vasil.pashov@man.com>
Configuration menu - View commit details
-
Copy full SHA for e6c4f28 - Browse repository at this point
Copy the full SHA e6c4f28View commit details
Commits on Apr 10, 2024
-
Feature flag the empty type using library config
Vasil Pashov committedApr 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 2effe0c - Browse repository at this point
Copy the full SHA 2effe0cView commit details -
Make empty index default to datetime to preserve behavior
Vasil Pashov committedApr 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 2d1512f - Browse repository at this point
Copy the full SHA 2d1512fView commit details
Commits on Apr 16, 2024
-
Vasil Pashov committed
Apr 16, 2024 Configuration menu - View commit details
-
Copy full SHA for 0e1f11c - Browse repository at this point
Copy the full SHA 0e1f11cView commit details -
Vasil Pashov committed
Apr 16, 2024 Configuration menu - View commit details
-
Copy full SHA for f8a8a66 - Browse repository at this point
Copy the full SHA f8a8a66View commit details
Commits on Apr 19, 2024
-
Expand empty index tests to cover pre-empty index behavior
Vasil Pashov committedApr 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 87ef604 - Browse repository at this point
Copy the full SHA 87ef604View commit details -
Vasil Pashov committed
Apr 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 3732304 - Browse repository at this point
Copy the full SHA 3732304View commit details
Commits on Apr 22, 2024
-
Bugfix 1509: Check RangeIndex start and step values when appending wi…
…th dynamic schema
Configuration menu - View commit details
-
Copy full SHA for 6fbe507 - Browse repository at this point
Copy the full SHA 6fbe507View commit details -
Bugfix 1507: Prevent appending row-range indexed dfs to datetime inde…
…xed dfs with dynamic schema
Configuration menu - View commit details
-
Copy full SHA for a550780 - Browse repository at this point
Copy the full SHA a550780View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.