Bugfix 1507+1509: dynamic schema different index append fixes #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th dynamic schema
…xed dfs with dynamic schema
This was referenced Apr 25, 2024
| } | ||
| auto stop = old_index->start() + old_length * old_index->step(); | ||
| normalization::check<ErrorCode::E_INCOMPATIBLE_INDEX>( | ||
| new_start == stop || (new_start == 0 && new_index->step() == 1), |
There was a problem hiding this comment.
is this going to allow something like this to happen
a
0 0
1 1
2 2
Append index (0, 1, 2)
a
0 0
1 1
2 2
0 3
1 4
2 5
Or is there some other check preventing it?
There was a problem hiding this comment.
We have to allow appending index [0, 1, 2 to index [0, 1, 2], otherwise our default behaviour when you don't provide an index won't work. We only store the start and step though, so it will come out as:
0 0
1 1
2 2
3 3
4 4
5 5
vasil-pashov
approved these changes
Apr 26, 2024
alexowens90
deleted the
bugfix/1507+1509/dynamic-schema-different-index-append-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1507
Closes #1509
While fixing, noticed that the added test
test_append_range_index_from_zerowould also not have passed, so fixed this too.