Adapt Raise to use format string as message directly if no args are given #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammadhamzasajjad
force-pushed
the
raise_formatter_update
branch
from
ef520d8
to
f61a398
Compare
muhammadhamzasajjad
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
muhammadhamzasajjad
force-pushed
the
raise_formatter_update
branch
from
f61a398
to
0f65523
Compare
muhammadhamzasajjad
changed the title
alexowens90
reviewed
Jun 21, 2024
cpp/arcticdb/util/preconditions.hpp
Outdated
| @@ -24,7 +24,13 @@ struct Raise { | |||
| template<typename...Args> | |||
| [[noreturn]] void operator()(fmt::format_string<Args...> format, Args&&...args) const { | |||
| std::string combo_format = fmt::format(FMT_COMPILE("{} {}"), error_code_data<code>.name_, format); | |||
There was a problem hiding this comment.
combo_format should be moved inside the else both here and below
alexowens90
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/man-group/arcticdb-man/issues/111
raise<ErrorCode>()function takes format string as the first argument. In some places this has been used incorrectly which leads errors like https://github.com/man-group/arcticdb-man/issues/111.sym{}as symbol namesym{}is handled correctly.Checklist
Checklist for code changes...