Make service alive checking more universal #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoebusm
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
phoebusm
force-pushed
the
feature/make_service_alive_checking_more_universal
branch
from
f1b274f
to
b8af42c
Compare
poodlewars
requested changes
Jun 11, 2024
| while True: | ||
| assert time.time() < deadline, f"Timed out waiting for {service} process to start" | ||
| assert alive(), service + " process died shortly after start up" | ||
| if "alive" in locals(): |
There was a problem hiding this comment.
Do not check locals() instead do something like this,
alive = lamba: True
b8af42c
to
4afb180
Compare
poodlewars
approved these changes
Jun 11, 2024
| @@ -92,7 +92,10 @@ def terminate(p: Union[multiprocessing.Process, subprocess.Popen]): | |||
|
|
|||
| def wait_for_server_to_come_up(url: str, service: str, process: ProcessUnion, *, timeout=20, sleep=0.2, req_timeout=1): | |||
| deadline = time.time() + timeout | |||
| alive = (lambda: process.poll() is None) if isinstance(process, subprocess.Popen) else process.is_alive | |||
| if process is not None: | |||
There was a problem hiding this comment.
(Nit) invert the if to avoid the double negative
phoebusm
force-pushed
the
feature/make_service_alive_checking_more_universal
branch
from
4afb180
to
66900fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
It is part of https://github.com/man-group/arcticdb-enterprise/issues/95.
The old design is limited to testing services spinned by
subprocess. I made it more universal for testing any url without the same requirement.What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...