Bugfix 1615: Fix segfault in benchmark_clause.cpp #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How long do the benchmarks take to run? Wonder if we should run them as part of the build to catch breaks. I did this recently in the enterprise repo. |
poodlewars
approved these changes
Jun 11, 2024
Seconds, no harm in including them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #1615
After the refactor to speed up hash-based grouping, the C++ grouping benchmark needs updating to correctly set the last logical row on the input column, as this is now used to presize the vector mapping rows to buckets.
Also noticed that some benchmarks did not make sense (e.g.
int8_tcolumn with 100,000 unique grouping values), so corrected this as well.