Enhancement/1610/method to force compact symbol list #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,7 +116,7 @@ class StorageLock { | |||
| OnExit x{[that=this] () { | |||
| that->mutex_.unlock(); | |||
| }}; | |||
| if(!ref_key_exists(store) || ttl_expired(store)) { | |||
| if(!ref_key_exists(store) || !ttl_not_expired(store)) { | |||
There was a problem hiding this comment.
I find double negatives hard to read.
There was a problem hiding this comment.
If I were refactoring I would probably replace both sides of the || with a single-line method whose name explains what is being checked if(no_lock_object_present() || lock_object_ttl_expired()
willdealtry
approved these changes
Jun 19, 2024
| @@ -116,7 +116,7 @@ class StorageLock { | |||
| OnExit x{[that=this] () { | |||
| that->mutex_.unlock(); | |||
| }}; | |||
| if(!ref_key_exists(store) || ttl_expired(store)) { | |||
| if(!ref_key_exists(store) || !ttl_not_expired(store)) { | |||
There was a problem hiding this comment.
If I were refactoring I would probably replace both sides of the || with a single-line method whose name explains what is being checked if(no_lock_object_present() || lock_object_ttl_expired()
jamesmunro
reviewed
Jun 19, 2024
alexowens90
force-pushed
the
enhancement/1610/method-to-force-compact-symbol-list
branch
from
24f9d79
to
10d9f07
Compare
alexowens90
deleted the
enhancement/1610/method-to-force-compact-symbol-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #1610
Considered augmenting
list_symbolsAPI to make this an option, but there are already a lot of arguments (particularly in theNativeVersionStoreversion) that this would not be compatible with, so added another method instead.