Fix symbol list bug on compaction (#1324) #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoDD
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
IvoDD
force-pushed
the
fix-compact-incomplete-symbol-list
branch
3 times, most recently
from
5263f73
to
521abee
Compare
vasil-pashov
approved these changes
Aug 29, 2024
alexowens90
requested changes
Sep 3, 2024
| @@ -1951,6 +1951,7 @@ def compact_incomplete( | |||
| metadata: Optional[Any] = None, | |||
| prune_previous_version: Optional[bool] = None, | |||
| validate_index: bool = False, | |||
| upsert_symbol_list: bool = True, | |||
There was a problem hiding this comment.
This shouldn't be a user facing option? For writes, we always write the symbol list key, for appends we only do if there is no version to append to?
IvoDD
force-pushed
the
fix-compact-incomplete-symbol-list
branch
from
521abee
to
ca475c5
Compare
- Only adds a symbol list entry on append if there is no previous version. - Fixes `finalize_staged_data` to write to the symbol list. - Adds a python test for the new behavior.
IvoDD
force-pushed
the
fix-compact-incomplete-symbol-list
branch
from
ca475c5
to
e9a7aca
Compare
alexowens90
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1324
What does this implement or fix?
finalize_staged_datato write to the symbol list.Any other comments?
Checklist
Checklist for code changes...