Refactor to storages to support async reads #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdealtry
changed the title
willdealtry
force-pushed
the
refactor_to_async
branch
2 times, most recently
from
0c6203a to
9a33876
Compare
alexowens90
reviewed
Dec 12, 2024
alexowens90
reviewed
Dec 12, 2024
alexowens90
reviewed
Dec 12, 2024
alexowens90
reviewed
Dec 12, 2024
alexowens90
reviewed
Dec 12, 2024
alexowens90
reviewed
Dec 12, 2024
alexowens90
approved these changes
Dec 16, 2024
willdealtry
force-pushed
the
refactor_to_async
branch
2 times, most recently
from
8061d37 to
b761182
Compare
willdealtry
force-pushed
the
refactor_to_async
branch
2 times, most recently
from
c8989e8 to
0486da9
Compare
willdealtry
force-pushed
the
refactor_to_async
branch
from
4977208 to
ec23fe7
Compare
poodlewars
reviewed
Jan 8, 2025
poodlewars
reviewed
Jan 8, 2025
poodlewars
reviewed
Jan 8, 2025
| blob_name, | ||
| static_cast<int>(e.StatusCode), | ||
| e.ReasonPhrase)); | ||
| } catch(const std::exception&) { |
There was a problem hiding this comment.
Why are we now catching std::exception here? Is this intentional? If so, why only for read?
poodlewars
reviewed
Jan 8, 2025
poodlewars
reviewed
Jan 8, 2025
poodlewars
reviewed
Jan 8, 2025
| if(!failed_deletes.empty()) | ||
| throw KeyNotFoundException(Composite<VariantKey>(std::move(failed_deletes))); | ||
| if (!failed_deletes.empty()) | ||
| throw KeyNotFoundException(failed_deletes); |
There was a problem hiding this comment.
poodlewars
reviewed
Jan 8, 2025
| request.WithBucket(bucket_name.c_str()).WithKey(s3_object_name.c_str()); | ||
| request.SetResponseStreamFactory(S3StreamFactory()); | ||
| ARCTICDB_RUNTIME_DEBUG(log::version(), "Scheduling async read of {}", s3_object_name); | ||
| s3_client.GetObjectAsync(request, GetObjectAsyncHandler{std::move(promise)}); |
There was a problem hiding this comment.
So the callback is executed in a thread pool managed by AWS SDK? Do we need to set its size somewhere or is it sensibly sized by default?
poodlewars
reviewed
Jan 8, 2025
|
|
||
| thread_local std::ostringstream oss; | ||
| for (int i = 0; i < num_frames; ++i) { | ||
| auto filtered = removePrefix(symbols[i], "/opt/arcticdb/arcticdb_link/python/arcticdb_ext.cpython-38-x86_64-linux-gnu.so"); |
There was a problem hiding this comment.
Can you drop a more general prefix? This stripping will only work for certain dev setups
poodlewars
reviewed
Jan 8, 2025
| @@ -1905,7 +1943,7 @@ void set_row_id_if_index_only( | |||
| if (read_query.columns && | |||
| read_query.columns->empty() && | |||
| pipeline_context.descriptor().index().type() == IndexDescriptor::Type::ROWCOUNT) { | |||
| frame.set_row_id(pipeline_context.rows_ - 1); | |||
| frame.set_row_id(static_cast<ssize_t>(pipeline_context.rows_ - 1)); | |||
There was a problem hiding this comment.
Not your problem, but confused why the row_id is a ssize_t but pipeline_context.rows_ is size_t
poodlewars
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Only important thing I spotted was this one #2012 (comment) otherwise looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap the storage methods in an async interface, add methods that return KeySegmentPairs directly, get rid of composite from the storage interface