Refactor to storages to support async reads #2012
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdealtry
changed the title
willdealtry
force-pushed
the
refactor_to_async
branch
2 times, most recently
from
0c6203a to
9a33876
Compare
alexowens90
reviewed
Dec 12, 2024
| @@ -244,11 +244,13 @@ std::vector<EntityId> push_entities(ComponentManager& component_manager, Process | |||
|
|
|||
| std::vector<EntityId> flatten_entities(std::vector<std::vector<EntityId>>&& entity_ids_vec); | |||
|
|
|||
| std::vector<folly::FutureSplitter<pipelines::SegmentAndSlice>> split_futures( | |||
| std::vector<folly::Future<pipelines::SegmentAndSlice>>&& segment_and_slice_futures); | |||
| std::vector<std::variant<folly::Future<pipelines::SegmentAndSlice>, folly::FutureSplitter<pipelines::SegmentAndSlice>>> split_futures( | |||
alexowens90
reviewed
Dec 12, 2024
| @@ -106,7 +105,7 @@ void iterate_snapshots(const std::shared_ptr<Store>& store, folly::Function<void | |||
| try { | |||
| visitor(vk); | |||
| } catch (storage::KeyNotFoundException& e) { | |||
| e.keys().broadcast([&vk, &e](const VariantKey& key) { | |||
| std::for_each(e.keys().begin(), e.keys().end(), [&vk, &e](const VariantKey& key) { | |||
There was a problem hiding this comment.
Could use std::ranges
alexowens90
reviewed
Dec 12, 2024
| #include "arcticdb/storage/storage_utils.hpp" | ||
| #include "arcticdb/storage/azure/azure_client_interface.hpp" | ||
| #include "azure_mock_client.hpp" | ||
| #include "arcticdb/storage/object_store_utils.hpp" |
alexowens90
reviewed
Dec 12, 2024
| #include "arcticdb/entity/atom_key.hpp" | ||
| #include "arcticdb/entity/serialized_key.hpp" | ||
| #include "arcticdb/util/string_utils.hpp" | ||
| #include "arcticdb/storage/lmdb/lmdb.hpp" |
alexowens90
reviewed
Dec 12, 2024
| @@ -22,6 +22,7 @@ S3ApiInstance::S3ApiInstance(Aws::Utils::Logging::LogLevel log_level) : | |||
| // Use correct URI encoding rather than legacy compat one in AWS SDK. PURE S3 needs this to handle symbol names | |||
| // that have special characters (eg ':'). | |||
| options_.httpOptions.compliantRfc3986Encoding = true; | |||
| //options_.httpOptions.httpClientFactory_create_fn = [](){ return Aws::MakeShared<ArcticHttpClientFactory>("ARCTICDB_HTTP_CLIENT"); }; | |||
There was a problem hiding this comment.
I guess remove the comment if not checking in ArcticHttpClientFactory
alexowens90
reviewed
Dec 12, 2024
| { | ||
| std::lock_guard lock{mutex_}; | ||
| ++data_[trace]; | ||
| ++count_; |
alexowens90
approved these changes
Dec 16, 2024
willdealtry
force-pushed
the
refactor_to_async
branch
from
17553ab to
8cf6aca
Compare
willdealtry
force-pushed
the
refactor_to_async
branch
from
8061d37 to
b761182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap the storage methods in an async interface, add methods that return KeySegmentPairs directly, get rid of composite from the storage interface