build: Replace emilib with robin_hood
#995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #331. Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
changed the title
emilib with robin_hood
Reason: MSVC has a bugs with template expansion when they are using `using`-declaration, which is the case for those operations and `robin_hood`. Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
|
Failures on the CI are unrelated to the changes proposed in this PR. |
willdealtry
approved these changes
Nov 6, 2023
|
|
JohanMabille
approved these changes
Nov 6, 2023
|
The last failures are not related to this PR but are related to #1035. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emilibis unmaintained and has no explicit OSI compliant licenses.For now
robin_hoodcan be used as a replacement for now without much loss in performance according to some benchmarks of its author.