Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cmdline check on nix #12

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Conversation

badgeratu
Copy link
Contributor

@badgeratu badgeratu commented Jul 22, 2021

Description

When running on a non-Windows platform, disable the attempt to obtain the command-line arguments for other running daprd processes as it requires a native system call that is currently only available on Windows.

The downside is that Sidekick will not be able to attach to an existing running daprd instance and may launch a second duplicate instance for the same AppId and AppPort, which would then fail to start (as Dapr doesn't allow multiple instances on the same machine with the same AppId). We can reinstate that functionality on *nix if a community member implements the required native system calls for querying command-line arguments.

Issue reference

Unable to load shared library 'kernel32.dll' on macOS #11

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation where possible

@badgeratu badgeratu requested a review from a-elsheikh July 22, 2021 16:06
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@57f8412). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   88.88%           
=======================================
  Files           ?      104           
  Lines           ?     2231           
  Branches        ?      453           
=======================================
  Hits            ?     1983           
  Misses          ?      159           
  Partials        ?       89           
Flag Coverage Δ
net35 85.43% <0.00%> (?)
net48 86.72% <0.00%> (?)
net5.0 88.28% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f8412...8b8d442. Read the comment docs.

@badgeratu badgeratu merged commit ee1044c into main Jul 22, 2021
@badgeratu badgeratu deleted the disable-cmdline-check-on-nix branch July 22, 2021 17:55
@badgeratu badgeratu linked an issue Jul 23, 2021 that may be closed by this pull request
@badgeratu badgeratu self-assigned this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to load shared library 'kernel32.dll' on macOS
3 participants