Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DAPRSIDEKICK_XXX variables #14

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

badgeratu
Copy link
Contributor

@badgeratu badgeratu commented Jul 28, 2021

Description

It is now possible to define DAPRSIDEKICK_XXX variables to set or override top-level configuration options. Note that this feature is limited to those options defined in the DaprProcessOptions base class which will equalluy apply to either the Sidecar, Placement or Sentry processes depending which is configured.

For example you can now set DAPRSIDEKICK_ENABLED=false to completely disable Dapr Sidekick, which is useful if you are running inside a pod/container where Dapr is injected separately.

Issue reference

Fixes Issue #9

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation where possible

@badgeratu badgeratu added this to the v1.1 milestone Jul 28, 2021
@badgeratu badgeratu requested a review from a-elsheikh July 28, 2021 11:11
@badgeratu badgeratu self-assigned this Jul 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #14 (92908a4) into main (ee1044c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   88.88%   88.90%   +0.01%     
==========================================
  Files         104      104              
  Lines        2231     2235       +4     
  Branches      453      453              
==========================================
+ Hits         1983     1987       +4     
  Misses        159      159              
  Partials       89       89              
Flag Coverage Δ
net35 85.43% <ø> (ø)
net48 86.78% <ø> (+0.05%) ⬆️
net5.0 88.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Man.Dapr.Sidekick/Options/DaprOptions.cs 100.00% <ø> (ø)
...NetCore/DaprSidekickServiceCollectionExtensions.cs 97.14% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1044c...92908a4. Read the comment docs.

@badgeratu badgeratu linked an issue Jul 28, 2021 that may be closed by this pull request
@badgeratu badgeratu merged commit 56d7385 into main Jul 28, 2021
@badgeratu badgeratu deleted the support_environment_variables_9 branch July 28, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support environment variables for Dapr Sidekick settings
3 participants