#365: fixed display issues with KDE

man-group · Dec 24, 2020 · 9a99f9e · 9a99f9e
1 parent d7d713e
commit 9a99f9e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/dtale/views.py b/dtale/views.py
@@ -2311,7 +2311,7 @@ def build_kde(s, hist_labels, code, return_data):
         try:
             kde = sts.gaussian_kde(s)
             kde_data = kde.pdf(hist_labels)
-            kde_data = [json_float(k) for k in kde_data[1:]]
+            kde_data = [json_float(k, precision=8) for k in kde_data]
             code.append("import scipy.stats as sts\n")
             code.append("kde = sts.gaussian_kde(s['{}'])".format(selected_col))
             code.append("kde_data = kde.pdf(np.linspace(labels.min(), labels.max()))")

diff --git a/static/popups/analysis/columnAnalysisUtils.js b/static/popups/analysis/columnAnalysisUtils.js
@@ -71,6 +71,7 @@ function buildHistogramAxes(baseCfg, fetchedData, _chartOpts) {
       scaleLabel: { display: true, labelString: "KDE" },
       id: "y-2",
       position: "right",
+      ticks: { min: 0, max: _.max(kde) },
     });
     datasets = _.concat(
       _.assignIn(

diff --git a/tests/dtale/test_views.py b/tests/dtale/test_views.py
@@ -1921,7 +1921,7 @@ def test_get_column_analysis_kde():
                 query_string=dict(col="a", type="histogram", bins=50),
             )
             response_data = json.loads(response.data)
-            assert len(response_data["kde"]) == 50
+            assert len(response_data["kde"]) == 51
 
 
 CORRELATIONS_CODE = """# DISCLAIMER: 'df' refers to the data you passed in when calling 'dtale.show'