Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correlations window #116

Closed
reza1615 opened this issue Mar 25, 2020 · 4 comments
Closed

correlations window #116

reza1615 opened this issue Mar 25, 2020 · 4 comments

Comments

@reza1615
Copy link

1- The window opens out of the monitor screen
2-There is two "<> Code Export" in that window the top one doesn't work

@aschonfeld
Copy link
Collaborator

So the reason for opening out of the main tab is because the popup is quite large and I didn't want to block user's view of the main grid. If you think opening a new tab rather than a popup window for correlations I can do that.

I'll take a look at the code export buttons. Good catch :)

@aschonfeld
Copy link
Collaborator

Ok, I see the issue with the top code export button. So its no longer clickable on the demo because the "Fork me on Github" link is actually blocking it. I can look into trying to fix that or even maybe using a different icon that will go in the bottom right-hand corner. I don't want to limit it completely because I need my stars :) since that's what my superiors use to measure whether working on D-Tale is time well spent or not. :(

@aschonfeld
Copy link
Collaborator

The best I could do was making the icon smaller so that now you have the ability to click on the html icon & the "Co"
image

aschonfeld pushed a commit that referenced this issue Mar 26, 2020
[#114](#114) added "Export CSV" link
[#113](#113) updates to "Value Counts" chart in "Column Analysis" for number of values and ordinal entry
aschonfeld pushed a commit that referenced this issue Mar 28, 2020
* #84, highlight columns based on dtype
* #92, build columns with random values
* #111, code export has syntax error & str() fix for column builder names
* #116, updated styling of github fork link
* #114, added "Export CSV" link
* #113, updates to "Value Counts" chart in "Column Analysis" for number of values and ordinal entry
* #120, allowing for duplicates in bar charts
* #119, fixed bug with queries not being passed to functions
* #114, added the ability to export dataframes to CSV/TSV
* added "category breakdown" in column analysis popup for float columns
* fixed bug where previous "show missing only" selection was not being recognized
aschonfeld pushed a commit that referenced this issue Mar 28, 2020
* #84, highlight columns based on dtype
* #92, build columns with random values
* #111, code export has syntax error & str() fix for column builder names
* #116, updated styling of github fork link
* #114, added "Export CSV" link
* #113, updates to "Value Counts" chart in "Column Analysis" for number of values and ordinal entry
* #120, allowing for duplicates in bar charts
* #119, fixed bug with queries not being passed to functions
* #114, added the ability to export dataframes to CSV/TSV
* added "category breakdown" in column analysis popup for float columns
* fixed bug where previous "show missing only" selection was not being recognized
aschonfeld pushed a commit that referenced this issue Mar 28, 2020
* #84, highlight columns based on dtype
* #92, build columns with random values
* #111, code export has syntax error & str() fix for column builder names
* #116, updated styling of github fork link
* #114, added "Export CSV" link
* #113, updates to "Value Counts" chart in "Column Analysis" for number of values and ordinal entry
* #120, allowing for duplicates in bar charts
* #119, fixed bug with queries not being passed to functions
* #114, added the ability to export dataframes to CSV/TSV
* added "category breakdown" in column analysis popup for float columns
* fixed bug where previous "show missing only" selection was not being recognized
aschonfeld pushed a commit that referenced this issue Mar 28, 2020
* #84, highlight columns based on dtype
* #92, build columns with random values
* #111, code export has syntax error & str() fix for column builder names
* #116, updated styling of github fork link
* #114, added "Export CSV" link
* #113, updates to "Value Counts" chart in "Column Analysis" for number of values and ordinal entry
* #120, allowing for duplicates in bar charts
* #119, fixed bug with queries not being passed to functions
* #114, added the ability to export dataframes to CSV/TSV
* added "category breakdown" in column analysis popup for float columns
* fixed bug where previous "show missing only" selection was not being recognized
aschonfeld pushed a commit that referenced this issue Mar 28, 2020
* #84, highlight columns based on dtype
* #92, build columns with random values
* #111, code export has syntax error & str() fix for column builder names
* #116, updated styling of github fork link
* #114, added "Export CSV" link
* #113, updates to "Value Counts" chart in "Column Analysis" for number of values and ordinal entry
* #120, allowing for duplicates in bar charts
* #119, fixed bug with queries not being passed to functions
* #114, added the ability to export dataframes to CSV/TSV
* added "category breakdown" in column analysis popup for float columns
* fixed bug where previous "show missing only" selection was not being recognized
aschonfeld pushed a commit that referenced this issue Mar 28, 2020
* #84, highlight columns based on dtype
* #92, build columns with random values
* #111, code export has syntax error & str() fix for column builder names
* #116, updated styling of github fork link
* #114, added "Export CSV" link
* #113, updates to "Value Counts" chart in "Column Analysis" for number of values and ordinal entry
* #120, allowing for duplicates in bar charts
* #119, fixed bug with queries not being passed to functions
* #114, added the ability to export dataframes to CSV/TSV
* added "category breakdown" in column analysis popup for float columns
* fixed bug where previous "show missing only" selection was not being recognized
@aschonfeld
Copy link
Collaborator

fixed in v1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants