Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dtype when mouse over the column name & main menu descriptions #129

Closed
reza1615 opened this issue Mar 29, 2020 · 16 comments
Closed

Show dtype when mouse over the column name & main menu descriptions #129

reza1615 opened this issue Mar 29, 2020 · 16 comments

Comments

@reza1615
Copy link

Showing dtype when the mouse hovers the column name. Now highlight type is perfect but it doesn't have any color legend. In my opinion, the best legend could Mouseover text box.

@reza1615
Copy link
Author

Also, the Mouseover tip/help/description for the main menu is not set.

aschonfeld pushed a commit that referenced this issue Mar 29, 2020
* #129, show dtype when hovering over header in "Highlight Dtypes" mode
* made "No Aggregation" the default aggregation in charts
* bugfix for line charts with more than 15000 points
* updated "Value Counts" & "Category Breakdown" to return top on initial load
@aschonfeld
Copy link
Collaborator

I’ve added data type display on hover of column headers when you’ve turned on “Highlight Dtypes” but i dont think I understand your second comment.

@reza1615
Copy link
Author

reza1615 commented Mar 29, 2020

In the main menu all buttons dont have moreover text. for example when I move mouse over describe it should show some tip description like "describing data columns such as number of unique items, min, max ,..."

@aschonfeld
Copy link
Collaborator

@reza1615 if you want to supply me with descriptions for the buttons I'll be more than happy to add mousehovers

@reza1615
Copy link
Author

@aschonfeld: please fill free to edit it.

  • Describe > "Describe column's values (Top unique values, Min, Max, Sum, STD, Var,...)"
  • Filter > "Defining custom Filtering for the main spreadsheet, Charts, ..."
  • Build Column > "Creating a/multi new column based on the existing columns or random values"
  • Reshape (In my opinion should be Summarizing table) > "Creating new PIVOT table, Aggregated table GroupBy, Transpose"
  • Correlations > "Presenting correlations matrix and chart"
  • Charts > "Plot chart (liner, scatterplot, bar chart, Pie, Map,...)"
  • HeatMap > "Presenting heatmap for numerical values in the main table"
  • Highlight Dtypes > "Highlight columns based on pandas dtypes. For dtype's name hover the mouse over column name"
  • Instances (In my opinion should be Sheets) > "Show existing data sheets"
  • Export > "Download DataFrame as CSV or TSV"
  • Refreshing widths > "Auto-Resize the column widths"
  • About > "Link to the source code repository, documentation"

@aschonfeld
Copy link
Collaborator

@reza1615 this is great! Thank you. Documentation has never been my strong suit so this really helps. I'll get to work adding this and show you a sample...

@aschonfeld
Copy link
Collaborator

@reza1615 Took a little longer than I thought, but I was able to add the descriptions. Let me know what you think
https://youtu.be/1kvlzeAfmCE

@reza1615
Copy link
Author

That is Great. Thanks.

@reza1615
Copy link
Author

shutdown > "Close D-Tale and its instances without save. do you want to export DataFrame?"

aschonfeld pushed a commit that referenced this issue Mar 31, 2020
* #129, description tooltips added main menu
aschonfeld pushed a commit that referenced this issue Apr 2, 2020
* #129, show dtype when hovering over header in "Highlight Dtypes" mode and description tooltips added to main menu
* made "No Aggregation" the default aggregation in charts
* bugfix for line charts with more than 15000 points
* updated "Value Counts" & "Category Breakdown" to return top on initial load
* #118, added scattergeo & choropleth maps
* #121, added "not equal" toggle to filters
* #132, updated resize button to "Refresh Widths"
* added "Animate" toggle to scatter, line & bar charts
* #131, changes to "Reshape Data" window
* #130, updates to pivot reshaper
* #128, additional hover display of code snippets for column creation
* #112, updated "Group" selection to give users the ability to select group values
aschonfeld pushed a commit that referenced this issue Apr 2, 2020
* #129, show dtype when hovering over header in "Highlight Dtypes" mode and description tooltips added to main menu
* made "No Aggregation" the default aggregation in charts
* bugfix for line charts with more than 15000 points
* updated "Value Counts" & "Category Breakdown" to return top on initial load
* #118, added scattergeo & choropleth maps
* #121, added "not equal" toggle to filters
* #132, updated resize button to "Refresh Widths"
* added "Animate" toggle to scatter, line & bar charts
* #131, changes to "Reshape Data" window
* #130, updates to pivot reshaper
* #128, additional hover display of code snippets for column creation
* #112, updated "Group" selection to give users the ability to select group values
@aschonfeld aschonfeld mentioned this issue Apr 2, 2020
aschonfeld pushed a commit that referenced this issue Apr 2, 2020
* #129, show dtype when hovering over header in "Highlight Dtypes" mode and description tooltips added to main menu
* made "No Aggregation" the default aggregation in charts
* bugfix for line charts with more than 15000 points
* updated "Value Counts" & "Category Breakdown" to return top on initial load
* #118, added scattergeo & choropleth maps
* #121, added "not equal" toggle to filters
* #132, updated resize button to "Refresh Widths"
* added "Animate" toggle to scatter, line & bar charts
* #131, changes to "Reshape Data" window
* #130, updates to pivot reshaper
* #128, additional hover display of code snippets for column creation
* #112, updated "Group" selection to give users the ability to select group values
@reza1615
Copy link
Author

reza1615 commented Apr 2, 2020

Would you please change css to show the mouseover in the broswer window? check demo.
image

@aschonfeld
Copy link
Collaborator

aschonfeld commented Apr 2, 2020

That doesn't seem to happen to me on the demo site
image
Did you shrink your browser down super small or something?

Doesn't happen to me when I turn on the dtype highlighting either.

Works for me in Chrome, IE 11 & IE Edge

@aschonfeld aschonfeld changed the title Show dtype when mouse over the column name Show dtype when mouse over the column name & main menu descriptions Apr 2, 2020
@reza1615
Copy link
Author

reza1615 commented Apr 2, 2020

hmm I have two monitors and it was on the right side. now i test it on the left monitor and it was ok. Maybe it is a bug which we should report to the plotly.

on the left monitor
image

@aschonfeld
Copy link
Collaborator

I have two monitors and I just tested it on each and both had the same correct behavior 🤷‍♂

Just to be clear this would be a CSS issue not plotly. plotly only controls the "Charts" page. Everything else is using custom ReactJS components. For example:
main grid -> react-virtualized
popups -> react-modal-bootstrap
dropdowns -> react-select (plotly/dash happens to use the same thing)
datetime inputs -> @blueprintjs/datetime
etc...

I'm calling this one closed.

@reza1615
Copy link
Author

reza1615 commented Apr 2, 2020

I use windows 10 is your OS windows?

@aschonfeld
Copy link
Collaborator

I am currently on windows 10, but I think the issue might lie with the browser you're using. I've tested it on the following with no issue:

  • IE11 (just locally there's a fix I need to deploy to get the grid to render)
  • Microsoft Edge 41.16299.1480.0 (just locally there's a fix I need to deploy to get the grid to render)
  • Chrome 80.0.3987.149
  • Firefox 72.0.2

@reza1615
Copy link
Author

reza1615 commented Apr 2, 2020

It is so strange now it is not producible!!
I tested on producible

  • Chrome Version 80.0.3987.149 (Official Build) (64-bit)

Anyway now it works properly. Thanks for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants