Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Douplicates #288

Closed
reza1615 opened this issue Oct 11, 2020 · 8 comments
Closed

Douplicates #288

reza1615 opened this issue Oct 11, 2020 · 8 comments

Comments

@reza1615
Copy link

reza1615 commented Oct 11, 2020

Thank you for implementing duplicates function. It is very handy.
would you please add these enhancements:

  • pleases also add it to the column description pop up window
    image
  • In the Show duplicates, the preview part, needs a vertical scroll bar. for some cases like city column it has many results and long window
    image
  • Mentioning the total number of rows and remaining rows in the remove duplicates window
    image
  • Please make the duplicate preview as pop up window like correlations window or Column Analysis. now it is an instance window.
@aschonfeld
Copy link
Collaborator

Not sure I understand the last request. Correlations will always spawn a new tab and Column Analysis will spawn a modal or a popup window depending on the current dimensions of your browser.

Currently the Duplicates has the same behavior as Column Analysis. I did find a bug with when it opens popup window rather than a modal. Other than that everything seems fine.

As for clicking "Execute" theres not much wiggle room on how that opens a new instance of D-Tale. I can add a button to the main menu to "drop this instance" if you'd like?

@reza1615
Copy link
Author

reza1615 commented Oct 16, 2020

The last request:
Show duplicates > Group by ( category_val) > view duplicates >> shows some cases. > select "DDDDD" > press Exceute.
It creates a new instance like http://alphatechadmin.pythonanywhere.com/dtale/main/5 . In my opinion it should create a page like http://alphatechadmin.pythonanywhere.com/dtale/popup/describe/4 which is not instance.
Use case:
for example we have a data set with many duplicates. I want to explore each cases to know should I take care about them. so I will have many instances which are useful just for one time exploration after that they should be removed.
Auto remove instance + Back to Data button are good options other wise please make it like /dtale/popup/describe/4 as a temporary data show

@aschonfeld
Copy link
Collaborator

Ok, that is a much longer term change. For the time being just use the new instance for viewing and you can view the "Describe" associated with it and when you don't need it anymore simply go to the "Instances" popup and delete the instance.

aschonfeld added a commit that referenced this issue Oct 16, 2020
* [#299](#299): Value counts not matching top unique values in Column Analysis
* [#298](#298): Standardize column builder bug
* [#297](#297): Similarity bugs
* [#290](#290): show top 5 values with highest frequency in describe details
* [#288](#288): Add Duplicates popup to Column Menu
aschonfeld added a commit that referenced this issue Oct 16, 2020
* #299: Value counts not matching top unique values in Column Analysis
* #298: Standardize column builder bug
* #297: Similarity bugs
* #290: show top 5 values with highest frequency in describe details
* #288: Add Duplicates popup to Column Menu
@aschonfeld
Copy link
Collaborator

fixed in v1.18.1

@reza1615
Copy link
Author

@aschonfeld : Thank you for efforts.
The second request isn't resolved and still there is long list

@aschonfeld
Copy link
Collaborator

Sorry, already have a fix for it. That will be included in the next release

@reza1615
Copy link
Author

reza1615 commented Oct 17, 2020

I checked and it doesn't have vertical scroll

@aschonfeld
Copy link
Collaborator

aschonfeld commented Oct 17, 2020

Hahaha, slow down I haven't released it yet. Hence "next release"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants