Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show duplicates has a bug #289

Closed
reza1615 opened this issue Oct 11, 2020 · 4 comments
Closed

Show duplicates has a bug #289

reza1615 opened this issue Oct 11, 2020 · 4 comments

Comments

@reza1615
Copy link

reza1615 commented Oct 11, 2020

  1. Please check Show duplicates > Bathrooms > 0
    it should show cases with Bathrooms ==0 and the number of records should be 119 rows. now it shows unrelated records (http://alphatechadmin.pythonanywhere.com/dtale/main/7)

  2. Show duplicates and execute has bug:
    Show duplicates > group by exterior color > execute dtale replace the exterior color with Null and shows an error. may be because I didn't select any case. in my opinion when any case aren't selected the Execute button should be inactive
    image

@aschonfeld
Copy link
Collaborator

  1. seems to work for me no problem
  2. The execute button should still work even without a selection. That just means you want to filter all duplicates and not just specific groups. This worked fine for me. I can add display of the total number of duplicates at the top of all the groups though.

@reza1615
Copy link
Author

@aschonfeld
Copy link
Collaborator

So I did some testing locally and everything seemed to work fine. I found a bug with selecting a specific group of duplicates when the column you're grouping on has spaces in its name. (this will be included in the next release)

I was able to see the error you had on the demo site, but once again I'm going to have to chalk it up to the fact that the demo site is hosted in an odd way where I believe pythonanywhere spins up multiple instances of the app and so each request isn't necessarily the same instance you were working off and create some odd behavior. If you're able to see this behavior when using the tool locally then I'd be more worried.

aschonfeld added a commit that referenced this issue Oct 17, 2020
* #305: Show Duplicates column(s) label
* #304: Link to Custom Filter from Column Menu
* #301: Normalized Similarity
* #289: Show Duplicates query bug & scrollable duplicate groups
@aschonfeld
Copy link
Collaborator

fixed in v1.18.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants