Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periods in column names cause page to go blank #63

Closed
beautah opened this issue Feb 14, 2020 · 7 comments
Closed

Periods in column names cause page to go blank #63

beautah opened this issue Feb 14, 2020 · 7 comments

Comments

@beautah
Copy link

beautah commented Feb 14, 2020

If a data frame column has a period in the name, as in 'meta.site_id' the rendered page goes blank as soon as you click on that column. No errors logged, just blank screen.

dtale 1.7.3
pandas 0.25.1

``

@aschonfeld
Copy link
Collaborator

@beautah good catch! I've been meaning to fix that. We saw it when using pd.read_json and if you had JSON objects multiple levels deep it concatenates them with periods in the column name. Thus causing the same issue.

Would you be alright with me simply replacing any periods in column names underscores?

@beautah
Copy link
Author

beautah commented Feb 14, 2020 via email

@aschonfeld
Copy link
Collaborator

I'll let you know when the fix is in. For the time being I think theres a sep argument you can set in pd.json_normalize

aschonfeld pushed a commit that referenced this issue Feb 15, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
aschonfeld pushed a commit that referenced this issue Feb 17, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
aschonfeld pushed a commit that referenced this issue Feb 18, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
@jboscolo
Copy link

I think I am having the same problem with '#' in the column name. I don't think the problem is limited to periods :)

@aschonfeld
Copy link
Collaborator

@jboscolo, thanks for the heads up! I’m working on a release which includes the other fix. I’ll include this as well and dig into what other characters pandas doesnt like.

@aschonfeld
Copy link
Collaborator

So it looks like pandas has actually solved this issue, but it won't be available until the release of 1.1.0 commit|issue

that being said, I have found a possible work around that will allow me to not remove special characters (https://stackoverflow.com/questions/40045545/pandas-query-string-where-column-name-contains-special-characters)

aschonfeld pushed a commit that referenced this issue Feb 19, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 19, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 19, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 19, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 19, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 19, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 19, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 19, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 19, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 19, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 20, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
@aschonfeld aschonfeld mentioned this issue Feb 20, 2020
aschonfeld pushed a commit that referenced this issue Feb 20, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
aschonfeld pushed a commit that referenced this issue Feb 20, 2020
 - fix for #63, periods in column names
 - added json_loader CLI options
 - updated moving/locking of columns to be persisted to back-end as well as front-end
 - added the ability to show/hide columns
 - added column builder popup (#61)
@aschonfeld
Copy link
Collaborator

Fixed this in v.1.7.5. I ended up using this solution which will only work in Python3 and eventually when pandas does a new release it will handle this problem for us. Once that happens I'll make this code be conditional on that version of pandas being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants