Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacements do not accept „0“ as replacer #704

Closed
stewmehr opened this issue Oct 27, 2022 · 3 comments
Closed

Replacements do not accept „0“ as replacer #704

stewmehr opened this issue Oct 27, 2022 · 3 comments

Comments

@stewmehr
Copy link

stewmehr commented Oct 27, 2022

I have a column with numerical data. When I try to replace all nan values in that column with a raw value of 0, I am prompted to „Please enter a raw value!“. I guess I am doing something wrong. What would be the best approach to mirror fillna(0) functionality?

@aschonfeld
Copy link
Collaborator

@hwesterholt apologies for the issues. I'll be adding a fix for this in the next release. Will update when it's available.

@stewmehr
Copy link
Author

stewmehr commented Nov 2, 2022

@aschonfeld Please don't feel the need to apologise. Dtale is absolutely mindblowing and I cannot tell you how many hours it has saved me already. I would have loved to try and contribute a fix myself, but my typescript foo is non-existent. Your efforts are highly appreciated!

@aschonfeld
Copy link
Collaborator

@hwesterholt thank you for the kind words. I've just release v2.9.0 to pypi (soon to be on conda-forge) with this fix. Let me know how it goes.

P.S. If you haven't already please toss your ⭐ on the repo. Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants