Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code generation - why not use df.drop for column deletion in generated code ? it currently uses list comprehension #748

Closed
jj-github-jj opened this issue Mar 31, 2023 · 2 comments
Closed

code generation - why not use df.drop for column deletion in generated code ? it currently uses list comprehension #748

jj-github-jj opened this issue Mar 31, 2023 · 2 comments

Comments

@jj-github-jj
Copy link

Trying to figure out why the generated code uses a long list comprehension for deleting columns instead of a simpler, abbreviated df.drop method
@aschonfeld
Copy link
Collaborator

@jj-github-jj no reason at all, I will update the code to use that instead. Good catch

aschonfeld added a commit that referenced this issue Apr 10, 2023
@aschonfeld
#748: update auto-generated column deletion code
de5f969
aschonfeld added a commit that referenced this issue Apr 10, 2023
@aschonfeld
#748: update auto-generated column deletion code
343686b
@aschonfeld
Copy link
Collaborator

@jj-github-jj just released v2.14.0 to pypi (should be on conda-forge shortly) with this update. Also, if you haven't already, please put your ⭐ on the repo when you get a sec. Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aschonfeld @jj-github-jj