Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmaps break locked columns #800

Closed
ms32035 opened this issue Sep 11, 2023 · 5 comments
Closed

Heatmaps break locked columns #800

ms32035 opened this issue Sep 11, 2023 · 5 comments

Comments

@ms32035
Copy link

ms32035 commented Sep 11, 2023

In my dataframe of several columns I have 5 locked columns (3 text, and 2 numeric). When I switch to highlight to heatmap (by columns or overall) the locked text columns are hidden, and as a result I see 5 numeric columns as locked columns. I guess the correct way would be to not hide locked columns in the heatmap view

@aschonfeld
Copy link
Collaborator

aschonfeld commented Sep 13, 2023

So the reason for certain columns being hidden is that they can't correctly be used in the heatmap calculation. IF you want to display everything (anything that can't be calculation correctly just gets displayed in gray background) you can click this option:
Screenshot 2023-09-13 at 12 23 00 PM

I can certainly look into the scenario where you haven't clicked that option and you have columns locked that can't be included in the heatmap calculation. It appears that those column disappear and then it hides the next unlocked columns it's place.

@ms32035
Copy link
Author

ms32035 commented Sep 13, 2023

Thanks, the latter is exactly the scenario I am describing

aschonfeld added a commit that referenced this issue Sep 13, 2023
aschonfeld added a commit that referenced this issue Sep 14, 2023
@aschonfeld
Copy link
Collaborator

@ms32035 just release v3.5.0 to pypi (will be on conda-forge shortly), which includes this fix. Let me know if you have any issues

@ms32035
Copy link
Author

ms32035 commented Sep 14, 2023

The behaviour changed in that now only the numeric columns remain locked, so the number of locked columns goes down from 5 to 2. Not sure if that's a desired/correct behavior, but I guess that's up to you to decided. Either way, thanks for looking at it so quickly 🚀

@aschonfeld
Copy link
Collaborator

I don't really know of any other option for behavior. If you select the "Show All Heatmap Columns" option then all 5 locked columns will remain. So in this instance it was the "desired" behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants