Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes & Updates #251

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Bugfixes & Updates #251

merged 1 commit into from
Aug 20, 2020

Conversation

aschonfeld
Copy link
Collaborator

* #243: column menu descriptions
* #247: code export compilation error fixes
* #242: type conversion column menu option & auto-column names on "Build Column"
* #235: nan formatting
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2020

Codecov Report

Merging #251 into master will increase coverage by 0.11%.
The diff coverage is 85.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   93.05%   93.16%   +0.11%     
==========================================
  Files         151      152       +1     
  Lines        8095     8140      +45     
  Branches      838      854      +16     
==========================================
+ Hits         7533     7584      +51     
+ Misses        311      304       -7     
- Partials      251      252       +1     
Flag Coverage Δ
#javascript 89.92% <85.11%> (+0.23%) ⬆️
#python 97.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
static/dtale/DataViewer.jsx 83.33% <ø> (-1.52%) ⬇️
static/dtale/serverStateManagement.jsx 83.60% <0.00%> (-1.40%) ⬇️
static/popups/create/createUtils.js 100.00% <ø> (ø)
static/popups/formats/StringFormatting.jsx 93.33% <ø> (ø)
static/dtale/column/ColumnMenu.jsx 95.50% <66.66%> (-1.05%) ⬇️
static/popups/create/CreateZScoreNormalize.jsx 78.94% <66.66%> (-3.41%) ⬇️
static/popups/create/CreateTypeConversion.jsx 86.55% <76.92%> (-0.95%) ⬇️
static/popups/formats/Formatting.jsx 93.33% <81.81%> (-2.83%) ⬇️
static/popups/popupUtils.jsx 82.43% <82.43%> (ø)
static/popups/create/CreateWinsorize.jsx 97.72% <85.71%> (+19.15%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317465a...e7b44bc. Read the comment docs.

@aschonfeld aschonfeld merged commit 8368b09 into master Aug 20, 2020
@aschonfeld aschonfeld deleted the bugfixes_20200816 branch November 10, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants