#224: Fix the use of Path, which renamed isdir() to is_dir(). #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morotti
reviewed
Aug 20, 2024
… the new is_dir() function.
jonbannister
force-pushed
the
224-fix-shutil
branch
from
96ad1ba to
b274dd8
Compare
jonbannister
force-pushed
the
224-fix-shutil
branch
from
f6d9e18 to
b1b9d10
Compare
jonbannister
force-pushed
the
224-fix-shutil
branch
from
b1b9d10 to
ebf746f
Compare
rspencer01
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace Path/path.py usages with pathlib.Path across the entire repo. Also removing references to outdated python versions and unused imports.
Why
To address #224 which is currently breaking a number of other builds since the renaming of Path::isdir() to Path::is_dir(). We don't really need the dependency since we can use functions from the standard library.