Skip to content

Commit

Permalink
ci: Test GCC 12 on Linux (#82)
Browse files Browse the repository at this point in the history
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
  • Loading branch information
jjerphan authored Apr 23, 2024
1 parent b95c03d commit 1992a64
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
# - {compiler: clang, version: '16', config-flags: '-DCMAKE_CXX_FLAGS=-stdlib=libc++', stdlib: 'libc++-17' }
- {compiler: clang, version: '17', config-flags: '', stdlib: 'libstdc++-13' }
# - {compiler: clang, version: '17', config-flags: '-DCMAKE_CXX_FLAGS=-stdlib=libc++', stdlib: 'libc++-17' }
- {compiler: gcc, version: '12', config-flags: '' }
- {compiler: gcc, version: '13', config-flags: '' }

config:
Expand Down
8 changes: 6 additions & 2 deletions include/sparrow/iterator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ namespace sparrow
it.advance(n);
}

#if _WIN32 // Workaround for access issue with msvc, when friend is involved
// On MSVC and GCC < 13, those methods need to be public to be accessible by friend functions.
#if _WIN32 || __GNUC__ < 13

public:

Expand All @@ -143,11 +144,14 @@ namespace sparrow
{
return lhs.less_than(rhs);
}
#if _WIN32 // Workaround for access issue with msvc, when friend is involved

// On MSVC and GCC < 13, those methods need to be public to be accessible by friend functions.
#if _WIN32 || __GNUC__ < 13

private:

#endif

template <class Derived, class E, class T, class R, class D>
friend class iterator_root_base;

Expand Down

0 comments on commit 1992a64

Please sign in to comment.