Add TODO

man-group · Apr 8, 2024 · 1a4959d · 1a4959d
1 parent 2763452
commit 1a4959d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/include/sparrow/typed_array.hpp b/include/sparrow/typed_array.hpp
@@ -43,7 +43,6 @@ template <class T, class L = get_default_layout_t<T>>
 class typed_array
 {
 public:
-
  using layout_type = L;
 
  using reference = typename layout_type::reference;

diff --git a/test/test_typed_array.cpp b/test/test_typed_array.cpp
@@ -40,7 +40,7 @@ namespace
  ad.buffers.push_back(b);
  ad.length = n;
  ad.offset = offset;
- ad.child_data.push_back(array_data());
+ ad.child_data.emplace_back();
  return ad;
  }
 
@@ -91,6 +91,8 @@ TEST_SUITE("typed_array")
  CHECK_EQ(typed_array_empty.cbegin(), typed_array_empty.cend());
  }
 
+ // TODO: Add tests for const_iterator: cbegin, cend
+
  TEST_CASE("bitmap")
  {
  const auto array_data = make_test_array_data(10, 1);