Skip to content

Commit

Permalink
Only install howardhinnant_date on macOS
Browse files Browse the repository at this point in the history
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
  • Loading branch information
jjerphan and JohanMabille committed Apr 25, 2024
1 parent 423082e commit 425d68b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/osx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ jobs:
run: |
echo " - clangxx==17.0.6" >> environment-dev.yml
- name: Add `howardhinnant_date` in the conda environment specification
run: |
# P0355R7 (Extending chrono to Calendars and Time Zones) has not been entirely implemented in libc++ yet.
# See: https://libcxx.llvm.org/Status/Cxx20.html#note-p0355
# For now, we use HowardHinnant/date as a replacement if we are compiling with libc++.
# TODO: remove this once libc++ has full support for P0355R7.
echo " - howardhinnant_date" >> environment-dev.yml
- name: Set conda environment
uses: mamba-org/setup-micromamba@main
with:
Expand Down
2 changes: 0 additions & 2 deletions environment-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,5 @@ dependencies:
# Build
- cmake
- ninja
# Alternative of `std::chrono` introduced in C++20.
- howardhinnant_date
# Tests
- doctest

0 comments on commit 425d68b

Please sign in to comment.