Dynamic bitset #17
Merged
Dynamic bitset #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanMabille
force-pushed
the
dynamic_bitset
branch
2 times, most recently
from
533ad48
to
7a0eedf
Compare
jjerphan
reviewed
Mar 12, 2024
include/sparrow/dynamic_bitset.hpp
Outdated
| using size_type = typename base_type::size_type; | ||
|
|
||
| dynamic_bitset(); | ||
| explicit dynamic_bitset(size_type n, value_type v = false); |
There was a problem hiding this comment.
Reminder of one of @Klaim's comment: two constructors need to be defined.
JohanMabille
force-pushed
the
dynamic_bitset
branch
from
f59c15d
to
fdd2d3f
Compare
Merged
JohanMabille
force-pushed
the
dynamic_bitset
branch
from
fdd2d3f
to
9041822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #16 , partially replaces #13
You can ignore the first 3 commits for the review (they will disappear when #16 is merged and this one is rebased).