Implemented variable_size_binary_layout #32
Conversation
JohanMabille
force-pushed
the
variable_size_layout
branch
2 times, most recently
from
569d3db
to
11d7b3b
Compare
| * - offset: [0, 6, 11, 13, 15, 24, 30] | ||
| * - data: ['p','l','e','a','s','e','a','l','l','o','w','m','e','t','o','i','n','t','r','o','d','u','c','e','m','y','s','e','l','f'] | ||
| * | ||
| * @tparam T the type of the data |
There was a problem hiding this comment.
So in the example it is char? or is it const char * or string?
There was a problem hiding this comment.
the value type is string. They are all stored as a contiguous buffer of char. I've added some precisions in the documentation.
There was a problem hiding this comment.
I would like a clarification in that specific comment line, that here the value type is the one stored in the data buffer, and not the byte representation of it.
|
|
||
| TEST_SUITE("variable_size_binary_layout") | ||
| { | ||
| TEST_CASE_FIXTURE(vs_binary_fixture, "types") |
There was a problem hiding this comment.
No need for a runtime test case when it's a bunch of compile-time checks.
I wonder if there is compile-time checks in doctest, I know there are in catch2 (I prefer doctest usually)
There was a problem hiding this comment.
I haven't found such a feature in doctest. I can move these assertions to the fixture class itself.
There was a problem hiding this comment.
Note that if any static assert needs to use that class, then the class must be defined before that use, so probably it's best to put them next but after that class.
There was a problem hiding this comment.
The static asserts are on the layout_type defined in the fixture class, so I guess it's fine to keep the static assert in the fixture class?
JohanMabille
force-pushed
the
variable_size_layout
branch
from
c8681a1
to
c1076a4
Compare
| const_bitmap_iterator bitmap_cbegin() const; | ||
| const_bitmap_iterator bitmap_cend() const; | ||
|
|
||
| bool has_value(size_type i) const; |
There was a problem hiding this comment.
| bool has_value(size_type i) const; | |
| bitmap_const_reference has_value(size_type i) const; |
Fix #39