Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang format #47

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Conversation

Alex-PLACET
Copy link
Collaborator

@Alex-PLACET Alex-PLACET commented Mar 27, 2024

Fix #42
There is no warning in the checks as we only check modified files.
You can test the rules with https://clang-format-configurator.site/
There are 2 cmake targets: a dry run and an auto fix which run over all the files.

@Alex-PLACET Alex-PLACET force-pushed the add_clang_format branch 2 times, most recently from 5d3a708 to 42f4b80 Compare April 3, 2024 13:34
@Alex-PLACET Alex-PLACET marked this pull request as ready for review April 5, 2024 06:49
Copy link
Collaborator

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @Alex-PLACET.

CMakeLists.txt Show resolved Hide resolved
cmake/clang-format.cmake Outdated Show resolved Hide resolved
cmake/clang-format.cmake Outdated Show resolved Hide resolved
cmake/clang-format.cmake Show resolved Hide resolved
cmake/clang-format.cmake Show resolved Hide resolved
cmake/clang-format.cmake Show resolved Hide resolved
.clang-format Show resolved Hide resolved
@Klaim
Copy link
Collaborator

Klaim commented Apr 5, 2024

This PR also needs to apply the formatting rules so that it is kept in sync with the code, and to also help with seeing if we need to consider some code to not format.

@Alex-PLACET Alex-PLACET merged commit 8d69576 into man-group:main Apr 9, 2024
21 checks passed
@Alex-PLACET Alex-PLACET deleted the add_clang_format branch April 9, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clang format rules
4 participants