Add value_ptr #59
Merged
Add value_ptr #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanMabille
reviewed
Apr 4, 2024
Klaim
reviewed
Apr 4, 2024
jjerphan
approved these changes
Apr 5, 2024
|
I think |
Klaim
reviewed
Apr 5, 2024
include/sparrow/memory.hpp
Outdated
| template <class T> | ||
| class value_ptr { | ||
| public: | ||
| value_ptr() = default; |
There was a problem hiding this comment.
unique_ptr is constexpr in C++23, I believe this type can also be written all constexpr although it might not work because of the calls to make_unique. Anyway, an attempt to make this type all constexpr would be helpful in the future.
There was a problem hiding this comment.
We only can support C++20 unfortunately, isn't it?
There was a problem hiding this comment.
This could be (locally) set to constexpr with a macro only defined when compiling with C++23.
JohanMabille
approved these changes
Apr 9, 2024
Add value_ptr documentation and update the test
Alex-PLACET
force-pushed
the
add_value_ptr
branch
from
5cabd05
to
1b46062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #57
Implement value_ptr class