Added iterator_adaptor, refactored pointer_iterator #62
Conversation
| template <class T> | ||
| class pointer_iterator; | ||
|
|
There was a problem hiding this comment.
Is this declaration needed since the class is defined hereinafter?
| template <class T> | |
| class pointer_iterator; |
There was a problem hiding this comment.
I tested the removal locally and this is actually required for reasons I am trying to understand.
There was a problem hiding this comment.
So actually this is a way to limit the definition of the pointer_iterator class to pointer template parameters:
- declare the class but do not implement it in the general case
- define the class for the T* specialization.
There was a problem hiding this comment.
As discussed IRL, we could define a concept to restrict the definition to pointers.
include/sparrow/iterator.hpp
Outdated
| template <class Iter> | ||
| requires std::same_as<Iter, std::remove_const_t<T>> | ||
| pointer_iterator(const Iter& iter) |
There was a problem hiding this comment.
Is the template type parameter Iter used to ease the signature instead of using a iterator_adaptor?
There was a problem hiding this comment.
This was supposed to allow to build a pointer_iterator<const T*> from a T*. But we're missing the pointer_iterator<T*> => pointer_iterator<const T*>, but the name Iter is confusing, and the implementation ifs wrong :s
This will make it easier to create other iterator adaptors.