-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement typed_array #65
Implement typed_array #65
Conversation
584f1ff
to
f16ba44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Alex-PLACET.
Here is a first review.
f16ba44
to
cc275a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this initial implementation. Here are a few comments, I find it easier to gather them rather than spreading them in the diff:
- Now that Layouts now store a reference to array_data instead of a value #51 is merged, the layout classes' copy and move semantics are deleted. Therefore the
typed_array
class should implement proper semantics. - Nitpicking: Since the API is going to grow, it could be nice to organize the different methods in the same order as std::vector, with the same sections (element access, iterators, etc). Notice that I am following the same "convention" in the incoming refactoring of the buffer class.
- Even if the buffer and the layout classes do not provide all the required methods to implement resize/insert/erase/clear, there are a couple of methods that can already be instantiated: front / back / data / empty (and I'm probably missing some of them)
- I think comparison operators can also be implemented
ec33d66
to
faa1997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A review with some outdated comments, I believe.
677f42f
to
1567e1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely LGTM.
I just have one comment.
47a9051
to
c0d8ee3
Compare
84b1e5d
to
3f8794b
Compare
Congrats on getting the PR in @Alex-PLACET ! |
Fix #61