Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managarm-system: use mold instead of ld #351

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

no92
Copy link
Member

@no92 no92 commented Jun 12, 2024

No description provided.

@no92
Copy link
Member Author

no92 commented Jun 12, 2024

Depends on managarm/managarm#683.

@no92 no92 marked this pull request as draft June 12, 2024 19:55
@ArsenArsen
Copy link
Member

(not against the change.. in fact, i have already messed with mold before, just curious)

what's the reason for this change?

@ElectrodeYT
Copy link
Member

(not against the change.. in fact, i have already messed with mold before, just curious)

what's the reason for this change?

It's quite a bit faster, and reduces iteration time by a decent amount, especially on slower machines, if a change is made that requires relinking several servers or other binaries.

@no92 no92 marked this pull request as ready for review June 16, 2024 08:47
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue

bootstrap.d/sys-devel.yml Show resolved Hide resolved
@no92
Copy link
Member Author

no92 commented Aug 21, 2024

Fixed the issue and rebased onto master.

Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dennisbonke Dennisbonke merged commit 1664758 into managarm:master Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants