bootstrap: Run {initialize-empty,remake}-image tasks in the container #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make host-limine not a containerless tool and build it using host-llvm-toolchain. The make-image task is still containerless because it actually mounts the disk image (either via loopback or guestfs), but ideally it shouldn't be, because it invokes 'strip' from cross-binutils, which just happens to work outside the container.
avdgrinten
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make host-limine not a containerless tool and build it using host-llvm-toolchain.
The make-image task is still containerless because it actually mounts the disk image (either via loopback or guestfs), but ideally it shouldn't be, because it invokes 'strip' from cross-binutils, which just happens to work outside the container.
Depends on qookei/image_create#2.