fix: #5051 PR comments #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
anaPerezGhiglia
force-pushed
the
spinoff/4824-multiple-acir-calls
branch
3 times, most recently
from
6437929 to
1f50548
Compare
anaPerezGhiglia
force-pushed
the
spinoff/4824-multiple-acir-calls
branch
from
1f50548 to
510c938
Compare
anaPerezGhiglia
force-pushed
the
spinoff/4824-multiple-acir-calls
branch
from
510c938 to
613a4f3
Compare
|
@ggiraldez @mverzilli I added some explanatory comments but I'm not confident about them, so feel free to suggest to change them completely |
ggiraldez
reviewed
Jun 21, 2024
* improve descriptive comments Co-authored-by: ggiraldez <ggiraldez@manas.tech>
ggiraldez
approved these changes
Jun 21, 2024
tooling/debugger/src/context.rs
Outdated
Comment on lines
33
to
37
| // The purpose of this structure is to map the opcode locations in ACIR circuits into | ||
| // a flat contiguous address space to be able to expose them to the DAP interface. | ||
| // In this address space, the ACIR circuits are laid out one after the other, and | ||
| // Brillig functions called from such circuits are expanded inline, replacing | ||
| // the `BrilligCall` ACIR opcode. |
There was a problem hiding this comment.
Oh, you can move this above the #[derive()] annotation above so it applies to the whole structure. I think you can also use /// (triple slashes) for the documentation system to pick it up.
tooling/debugger/src/context.rs
Outdated
| // the `BrilligCall` ACIR opcode. | ||
| // | ||
| // `addresses: Vec<Vec<usize>>`` | ||
| // * The first vec is `n` sized - one element per ACIR circuit |
There was a problem hiding this comment.
Minor nitpick: first -> outer
anaPerezGhiglia
merged commit 7e882df
into
feat/4824-multiple-acir-calls
37 checks passed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for addressing comments on noir-lang#5051
?operator and the type on which is operating is not the same as the one returned in the function - Option vs ResultAddressMapstruct for abstracting theVec<Vec<usize>>type that's needed to map between aDebugLocationand "virtual" addresses