Expose public state variables so that they are accessible through this

crates/solidity/inputs/language/bindings/rules.msgb

@@ -360,6 +360,15 @@ inherit .enclosing_def
  edge @contract.lexical_scope -> @member.def
 }
 
+;; Public state variables are also exposed as external member functions
+@contract [ContractDefinition [ContractMembers [ContractMember
+ @state_var [StateVariableDefinition
+ [StateVariableAttributes [StateVariableAttribute [PublicKeyword]]]
+ ]
+]]] {
+ edge @contract.members -> @state_var.def
+}
+
 @contract [ContractDefinition members: [ContractMembers
  item: [ContractMember @function variant: [FunctionDefinition]]
 ]] {
@@ -1243,17 +1252,16 @@ inherit .enclosing_def
  @type_name type_name: [TypeName]
  @name name: [Identifier]
 ] {
- node def
- attr (def) node_definition = @name
- attr (def) definiens_node = @state_var
+ attr (@state_var.def) node_definition = @name
+ attr (@state_var.def) definiens_node = @state_var
 
- edge @state_var.def -> def
+ edge @state_var.def -> @state_var.def
  edge @type_name.type_ref -> @state_var.lexical_scope
 
  node typeof
  attr (typeof) push_symbol = "@typeof"
 
- edge def -> typeof
+ edge @state_var.def -> typeof
  edge typeof -> @type_name.output
 }
 

crates/solidity/testing/snapshots/bindings_output/contracts/public_getters/generated/0.4.11-success.txt

@@ -0,0 +1,39 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+References and definitions: 
+ ╭─[input.sol:1:1]
+ │
+ 1 │ contract Foo {
+ │ ─┬─ 
+ │ ╰─── def: 1
+ 2 │ int public x;
+ │ ┬ 
+ │ ╰── def: 2
+ │ 
+ 5 │ contract Bar {
+ │ ─┬─ 
+ │ ╰─── def: 3
+ 6 │ int public y;
+ │ ┬ 
+ │ ╰── def: 4
+ 7 │ Foo f;
+ │ ─┬─ ┬ 
+ │ ╰───── ref: 1
+ │ │ 
+ │ ╰── def: 5
+ │ 
+ 9 │ function test() public returns (int) {
+ │ ──┬─ 
+ │ ╰─── def: 6
+ 10 │ return y + this.y() + f.x();
+ │ ┬ ──┬─ ┬ ┬ ┬ 
+ │ ╰─────────────────── ref: 4
+ │ │ │ │ │ 
+ │ ╰───────────── unresolved
+ │ │ │ │ 
+ │ ╰────────── ref: 4
+ │ │ │ 
+ │ ╰──── ref: 5
+ │ │ 
+ │ ╰── ref: 2
+────╯

crates/solidity/testing/snapshots/bindings_output/contracts/public_getters/input.sol

@@ -0,0 +1,12 @@
+contract Foo {
+ int public x;
+}
+
+contract Bar {
+ int public y;
+ Foo f;
+
+ function test() public returns (int) {
+ return y + this.y() + f.x();
+ }
+}