-
Notifications
You must be signed in to change notification settings - Fork 3
docs: Update README with containerless local development workflow #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Development Environment OptionsThis repository supports Dev Containers for a consistent development environment. Option 1: GitHub Codespaces (Recommended)Create a cloud-based development environment:
Option 2: VS Code Dev Containers (Local)Use Dev Containers on your local machine:
Option 3: Traditional Local SetupSet up the development environment manually: # Clone the repository
git clone https://github.com/manavgup/rag_modulo.git
cd rag_modulo
git checkout docs/update-readme-local-dev
# Initialize development environment
make dev-init
make dev-build
make dev-up
make dev-validate Available CommandsOnce in your development environment: make help # Show all available commands
make dev-validate # Validate environment setup
make test-atomic # Run atomic tests
make test-unit # Run unit tests
make lint # Run linting Services AvailableWhen running
This automated message helps reviewers quickly set up the development environment. |
PR Review: Documentation Update for Containerless DevelopmentOverall AssessmentVerdict: Approve with minor suggestions This PR significantly improves the developer experience by clearly documenting the containerless local development workflow. Strengths
Critical Issues (Must Fix Before Merge)1. Directory Name Inconsistency (CRITICAL)Lines 84, 98, 227 in README.md: References to Issue: According to CLAUDE.md, the frontend is in Fix: Change all 2. Hardcoded Personal PathIMMEDIATE_FIX.md line 14: Fix: Replace with generic instruction or remove personal path 3. Wrong Branch ReferenceIMMEDIATE_FIX.md line 40: Fix: Use generic placeholder like Code Quality Scores
SecurityNo security concerns - documentation only changes. RecommendationsBefore Merge (Critical):
Nice to Have (Follow-up):
Final RecommendationAPPROVE with requested changes Fix items 1-3 before merge. This is excellent work that will significantly improve developer onboarding. Reviewed by: Claude Code |
Major improvements to Quick Start and Development Workflow sections: Quick Start Reorganization: - Option 1: Local Development (⚡ Fastest - Recommended) - Step-by-step containerless setup - Clear venv activation instructions - When to use guidelines - Option 2: Production Mode (🐳 Docker) - For production-like testing - Pre-built GHCR images or local builds - Option 3: GitHub Codespaces (☁️ Cloud) - Quick experimentation and onboarding Development Workflow: - Recommended Daily Workflow section - Morning setup → dev cycle → cleanup - Essential commands table with use cases - Emphasizes local development speed Enhanced Troubleshooting: - Virtual Environment Issues (new) - Docker Infrastructure issues - Dependency management - Common tool version problems Philosophy: Develop locally without containers (fast), deploy with containers (production)
7fec0a5
to
a3f9352
Compare
Pull Request Review - Critical Issues FoundThank you for this comprehensive documentation update! This PR significantly improves the developer onboarding experience. However, I found several critical issues that need fixing before merge. CRITICAL: Missing Makefile TargetProblem: README recommends 'make run-infra' (lines 87, 224, 251) but this target does not exist in the Makefile. Reality: The actual target is 'local-dev-infra' (found at Makefile:327) Fix Required: Replace all 'make run-infra' with 'make local-dev-infra' at these locations:
Other Issues
Strengths
Verified CommandsTesting commands are accurate (verified in Makefile):
RecommendationOverall Assessment: 4/5 stars Status: Request Changes The documentation is excellent overall, but the broken 'make run-infra' command will cause immediate confusion for new developers. Once this critical issue is fixed, this will be ready to merge. Great work on improving the developer documentation! The containerless workflow is a significant improvement to development velocity. |
Summary
Major update to README.md to reflect our new containerless local development paradigm.
Changes
1. Quick Start Reorganization
Option 1: Local Development (⚡ Fastest - Recommended)
Option 2: Production Mode (🐳 Docker)
Option 3: GitHub Codespaces (☁️ Cloud)
2. Development Workflow
3. Enhanced Troubleshooting
🐍 Virtual Environment Issues:
make venv
problems🐳 Docker Issues: Infrastructure service troubleshooting
📦 Dependency Issues: Import errors and missing modules
Reference: Points to IMMEDIATE_FIX.md
4. Added Documentation
Philosophy
Develop locally without containers (maximum speed)
Deploy with containers (production readiness)
Related Issues
Addresses documentation needs after recent PR merges:
Prepares for future improvements: