Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download history management and other improvements #59

Open
wants to merge 574 commits into
base: main
Choose a base branch
from

Conversation

nbr23
Copy link

@nbr23 nbr23 commented Apr 15, 2020

Hello,

Adding a few features and updating the UI slightly while trying to remain in the original spirit:

  • Add download history and download log recording and viewing
  • Update Dockerfile to pull static files and serve them locally
  • Add queue size viewer in UI
  • Simplify endpoints
  • Update readme to reflect changes made

Update 23/04/2020:

  • Add rough subtitles download support

Update 25/04/2020:

  • Merge @gallofeliz 's improvements (UI adds with detailed stats, as well as recording of pending jobs in the db)
  • Resume pending jobs recorded by @gallofeliz in the db
  • Refactor sqlite works, aiming to have a more thread safe implementation
  • Update bookmarklet examples in README

Update 10/05/2020:

  • Merge @eikevons adding downloading file listing and links
  • Add retry option in log view for failed jobs

Update 10/06/2020:

Cheers!

@gallofeliz
Copy link

Very good job 👍 Suggestion : Add in the "logs" list the pending ones. Else we don't know what is in the pending queue ; and other reason : if the service is stopped, I feel that we loose all our pendings :'(

@gallofeliz
Copy link

I did it in https://github.com/gallofeliz/youtube-dl-server ;)

@nbr23
Copy link
Author

nbr23 commented Apr 25, 2020

Looks great @gallofeliz, refactoring a bit and adding resume on start, I'll merge with my fork later today.
I love the improved stats at the top right!

Cheers!

@nbr23
Copy link
Author

nbr23 commented Apr 26, 2020

Merged, @gallofeliz, and resuming the pendings on start now. Thanks again!

@gallofeliz
Copy link

Yes, it will be a great app :) I don't know Python so refactoring after me is good ahah !

Regards

@gallofeliz
Copy link

Hi,

I issue slow UI sometimes, I don't know why.
I updated logs to put same colors than stats ; but probably put colors on status badges should be more "discret".
I fixed main page height.

Regards

@nbr23
Copy link
Author

nbr23 commented Apr 26, 2020

Hi @gallofeliz do you have more details about the slowness you are seeing? Any specific actions that make it slow?
I saw your message about interrupted running jobs causing issues, but can't find the comment anymore, did this end up being a non issue?
Thanks for the cosmetic improvements!

@gallofeliz
Copy link

Hi @nbr23,

I removed the comment about interrupted running job because I didn't reproduce it. For me the job was ended because youtube-dl said it in the cli logs but maybe it needs a lot of time to finish the encoding or to write to the disk.

About the slow, I will see.

@gallofeliz
Copy link

I tested again and I issued slow pages, not stats. I issued slow main page and then slow logs page, but after that, no more, even if I reboot the service, I disable chromium cache, I go to Firefox. It's like ... random !

Regards.
Screenshot from 2020-04-26 18-32-53
Screenshot from 2020-04-26 18-33-16

@nbr23
Copy link
Author

nbr23 commented Apr 26, 2020

@gallofeliz ok weird, I have not seen any slownesses so far. I will keep an eye out.
Regarding the job you thought had ended, it can indeed take a long time for the post download conversion with ffmpeg, so what you saw was most likely that, ffmpeg working in the background still.

I've updated the logs page a little to just show the color on the status and not the whole line. That should make it easier on the eye ;)

@gallofeliz
Copy link

Yes good. I will stop to develop for the moment and begin to use :)

The next step for me is to be able to stop it correctly ... When I do CTRL-C, it doesn't stop. I need to do it 3 times. I don't know how to do, I tried exit(0) but without success.

Regards

@nbr23 nbr23 mentioned this pull request Jun 10, 2020
@nbr23 nbr23 changed the title Add download history management Add download history management and other improvements Jun 10, 2020
@fluential
Copy link

Is this still work in progress? any chance for merge?

@nbr23
Copy link
Author

nbr23 commented Jun 12, 2020

@fluential it is stable and can be merged

@fluential
Copy link

@manbearwiz can this be merged?

@fluential
Copy link

??

@jcat4
Copy link

jcat4 commented May 4, 2021

This is super dope... I've got the fork pulled and running great on my unRAID box. It'd be AMAZING to see this merged and given an official Community Apps release! 😁🤩

@nbr23 nbr23 force-pushed the master branch 4 times, most recently from 6964170 to 04ff741 Compare July 12, 2022 13:48
@williswschan
Copy link

This is the best youtube downloader I've seen by far. Longing for the newer version with file size showing for finished download.
one silly question would like check;
Does docker with tag "yt-dlp" mean using yt-dlp while "latest" is using youtube-dl? Somehow I realized the performance for youtube-dl is not good lately, that's why I'm quite eager to use yt-dlp instead. Thanks.

@nbr23
Copy link
Author

nbr23 commented Sep 8, 2022

Does docker with tag "yt-dlp" mean using yt-dlp while "latest" is using youtube-dl?

That is correct yes!

@nbr23 nbr23 force-pushed the master branch 2 times, most recently from 4403bdd to 3591a98 Compare February 22, 2023 02:57
Renovate Bot and others added 30 commits September 8, 2024 10:55
Bumps [rollup](https://github.com/rollup/rollup) from 4.21.2 to 4.24.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.2...v4.24.0)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants