Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extensions support and add path parameters to operation params #83

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

khizunov
Copy link
Contributor

@khizunov khizunov commented Feb 20, 2024

  • Extensions support in all supported objects
  • Add global path parameters to operation

@khizunov
Copy link
Contributor Author

@manchenkoff

@manchenkoff manchenkoff self-requested a review February 20, 2024 19:37
@manchenkoff manchenkoff added the enhancement New feature or request label Feb 20, 2024
Copy link
Owner

@manchenkoff manchenkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @khizunov, thanks a lot for the contribution! 🔥
Left one code-related minor comment, but there are some build issues.
Could you also add some unit tests as well? At least to check more complicated logic like passing extensions to each oauth flow and path parameters inheritance.

@khizunov khizunov force-pushed the anton/add-extensions branch from a8a3b4c to 916d068 Compare February 20, 2024 19:56
@khizunov
Copy link
Contributor Author

Hey @khizunov, thanks a lot for the contribution! 🔥 Left one code-related minor comment, but there are some build issues. Could you also add some unit tests as well? At least to check more complicated logic like passing extensions to each oauth flow and path parameters inheritance.

Hey @manchenkoff sure not problem at all, will do 👍

@manchenkoff
Copy link
Owner

Closes #42

@khizunov khizunov force-pushed the anton/add-extensions branch from 916d068 to 8a3769b Compare February 21, 2024 05:37
@khizunov
Copy link
Contributor Author

@manchenkoff good catch on Oauth flows 💯
Fixed the build, working on tests

@khizunov khizunov force-pushed the anton/add-extensions branch from 8a3769b to 189a921 Compare February 21, 2024 06:56
@khizunov
Copy link
Contributor Author

@manchenkoff added test cases for extensions
for the path parameters inheritance the cases are already there in path builder test and runner test.
LMK if you want me to add some other cases

@khizunov khizunov requested a review from manchenkoff February 21, 2024 07:42
tests/test_runner.py Show resolved Hide resolved
@manchenkoff
Copy link
Owner

I will publish new version later today, thanks @khizunov!

@manchenkoff manchenkoff merged commit ea47c84 into manchenkoff:master Feb 21, 2024
1 check passed
@manchenkoff
Copy link
Owner

published as v1.1.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants