Update for Python 3 (and add Pipfile for pipenv) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix a typo in the instructions for unzipping the ASN MMDB file - Open the output CSV in text mode, not binary mode - Switch to urllib.request instead of Python 2 urllib - Add `python-geoip-python3` dependency to resolve errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to use this script today, and found it nearly worked with Python 3, but needed a few tweaks. Hunted down the issues, and I'm submitting this PR here so other people can benefit from my trouble :)
python-geoip-python3dependency to resolve errorsTested this version on the sample data and it looks good, and I made mostly the same tweaks on my work machine and it worked well with real data.