ci: support multiple author in sync GH #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sync GH action only works for a single author, producing unexpected results when using list of authors. This change also prevent problems with new files that are not rules (`.yml`). (such as `.github/scripts/changelog_author.py`) Closes mandiant/capa#555
| import sys | ||
|
|
||
| rule_file = sys.argv[1] | ||
| with open(rule_file, 'r') as stream: |
There was a problem hiding this comment.
recommend: prefer to use rb with an explicit call to f.read().decode("utf-8")
no need to change here, just mentioning it
There was a problem hiding this comment.
can you please elaborate on why?
There was a problem hiding this comment.
to be clear, this is a personal style thing.
basically, because the behavior here is platform-dependent:
while it probably doesn't matter in this case (CI is always going to be linux, and files never shared across platforms) doing things explicitly prevents subtle bugs for creeping in when files might be shared. therefore, i default to using explicit encodings in all cases.
There was a problem hiding this comment.
Thanks for the explanation @williballenthin!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sync GH action only works for a single author, producing unexpected results when using list of authors.
This change also prevent problems with new files that are not rules (
.yml). (such as.github/scripts/changelog_author.py)Closes mandiant/capa#555