[CI] Use badge in gist for rules number in README #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ana06
added a commit
to Ana06/capa
that referenced
this pull request
Feb 23, 2024
Since the following PR, the README badge in capa is not updated anymore via commits anymore, but in a gist: mandiant/capa-rules#882
Ana06
added a commit
to Ana06/capa
that referenced
this pull request
Feb 23, 2024
Since mandiant/capa-rules#882, the README badge in capa is not updated anymore via commits anymore, but in a gist.
Ana06
added a commit
to Ana06/capa
that referenced
this pull request
Feb 23, 2024
Since mandiant/capa-rules#882, the README badge in capa is not updated anymore via commits anymore, but in a gist.
3 tasks
williballenthin
approved these changes
Feb 23, 2024
.github/workflows/sync.yml
Outdated
| uses: ad-m/github-push-action@master | ||
| echo "num_rules=$num_rules" >> $GITHUB_ENV | ||
| - name: Update dynamic badge gist | ||
| uses: schneegans/dynamic-badges-action@v1.7.0 |
There was a problem hiding this comment.
consider using the release's commit hash, as described here: mandiant/capa#2000 (comment)
mr-tz
approved these changes
Feb 23, 2024
This simplifies the workflow code and remove the need for the noisy commits in capa-rules. We still need the commits in capa to sync the submodule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not rely on
img.shields.io, simplifies the workflow code, and remove the need for the noisy commits in capa-rules. We still need the commits in capa to sync the submodule. I'll send a PR in capa to use the new badge in a moment.This requires giving the token gist persmissions, which I have already done. So it should work when we merge it.
We are using gist badges in VM-Packages since a few days, in case you want to see it working. We update the number of packages when adding a new package and the the daily package failures once a day.